Revert nullable Option.apply in stdlib #24230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
approved these changes
Oct 22, 2025
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
Oct 23, 2025
hamzaremmal
added a commit
to hamzaremmal/scala3
that referenced
this pull request
Oct 23, 2025
hamzaremmal
added a commit
that referenced
this pull request
Oct 24, 2025
…mNullable` (#24238) Yes, this is not the most ideal signature for `Option.apply` but it allows at least to drop `Option.fromNullable` and an easier migration to explicit nulls (no need to add `fromNullable` everywhere). Superseed #24231 in the sense where we focus here on the nullability issue rather than the more global issue. Reverts #24230 Relates to #24206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24206
Although
T | Nullis definitely a more correct signature forOption.apply(and one of the main motivation why we updated the stdlib), we decide to revert the changes related toOption.applyto avoid any breaking change in regular projects.See discussion in #24206